All filters rewritten to throw FilterChainException

[shipsimu.git] / application / ship-simu / main / filter / validator / class_RefillRequestValidatorFilter.php

diff --git a/application/ship-simu/main/filter/validator/class_RefillRequestValidatorFilter.php b/application/ship-simu/main/filter/validator/class_RefillRequestValidatorFilter.php
index 71e9b2ddbe80faf92febe758269138570f3c02bd..f5ca9e0f902cea95de53f5df1a215d591f457dcd 100644 (file)
--- a/application/ship-simu/main/filter/validator/class_RefillRequestValidatorFilter.php
+++ b/application/ship-simu/main/filter/validator/class_RefillRequestValidatorFilter.php
@@ -35,16 +35,12 @@ class RefillRequestValidatorFilter extends BaseShipSimuFilter implements Filtera
        /**
         * Creates an instance of this filter class
         *
-        * @param       $controllerInstance             An instance of a Controller class
-        * @return      $filterInstance                 An instance of this filter class
+        * @return      $filterInstance         An instance of this filter class
         */
-       public final static function createRefillRequestValidatorFilter (Controller $controllerInstance) {
+       public final static function createRefillRequestValidatorFilter () {
                // Get a new instance
                $filterInstance = new RefillRequestValidatorFilter();
 
-               // Set the controller
-               $filterInstance->setControllerInstance($controllerInstance);
-
                // Return the instance
                return $filterInstance;
        }
@@ -55,7 +51,8 @@ class RefillRequestValidatorFilter extends BaseShipSimuFilter implements Filtera
         * @param       $requestInstance        An instance of a class with an Requestable interface
         * @param       $responseInstance       An instance of a class with an Responseable interface
         * @return      void
-        * @todo        0% done
+        * @todo        Maybe we need to added some more generic tests on the request here?
+        * @throws      FilterChainException    If this filter fails to operate
         */
        public function execute (Requestable $requestInstance, Responseable $responseInstance) {
                // Execute the parent execute method
@@ -70,11 +67,8 @@ class RefillRequestValidatorFilter extends BaseShipSimuFilter implements Filtera
                        $responseInstance->addFatalMessage('refill_page_required_fields_missing');
 
                        // Abort here
-                       return false;
+                       throw new FilterChainException($this, self::EXCEPTION_FILTER_CHAIN_INTERCEPTED);
                } // END - if
-
-               // Unfinised part
-               $this->partialStub("Unfinished method.");
        }
 }