Not thrown exceptions removed from doc-tag, TODOs added and updated

[hub.git] / application / hub / main / resolver / state / network / class_NetworkStateResolver.php

diff --git a/application/hub/main/resolver/state/network/class_NetworkStateResolver.php b/application/hub/main/resolver/state/network/class_NetworkStateResolver.php
index e37e8380ffbe9ddc31cf6bad1e9db37fc746f2a5..925a37a052ccb7f9bc8c93e02656e30fe6edf8b4 100644 (file)
--- a/application/hub/main/resolver/state/network/class_NetworkStateResolver.php
+++ b/application/hub/main/resolver/state/network/class_NetworkStateResolver.php
@@ -48,9 +48,7 @@ class NetworkStateResolver extends BaseStateResolver implements StateResolver {
        /**
         * Creates an instance of a resolver class with a given state
         *
-        * @return      $resolverInstance                       The prepared state resolver instance
-        * @throws      EmptyVariableException          Thrown if default state is not set
-        * @throws      InvalidStateException   Thrown if default state is invalid
+        * @return      $resolverInstance       The prepared state resolver instance
         */
        public final static function createNetworkStateResolver () {
                // Create the new instance
@@ -66,7 +64,7 @@ class NetworkStateResolver extends BaseStateResolver implements StateResolver {
         * @param       $packageInstance        An instance of a package class
         * @param       $rawData                        The raw data
         * @return      $stateInstance          An instance of the resolved state
-        * @todo        0%
+        * @todo        ~30% done
         */
        public function resolveStateByPackage (Networkable $packageInstance, $rawData) {
                // Get error code
@@ -79,13 +77,15 @@ class NetworkStateResolver extends BaseStateResolver implements StateResolver {
                        $errorCode = BaseNetworkPackageHandler::SOCKET_ERROR_TRANSPORT_ENDPOINT;
                } elseif (is_int($errorCode)) {
                        // Debug output (because we might want to handle it like the above(s)
-                       $this->debugOutput(__METHOD__ . ': UNKNOWN ERROR CODE = ' . $errorCode);
+                       $this->debugOutput(__METHOD__ . ': UNKNOWN ERROR CODE = ' . $errorCode, ', MESSAGE = ' . socket_strerror($errorCode));
 
                        // Change it only in this class
                        $errorCode = BaseNetworkPackageHandler::SOCKET_ERROR_UNKNOWN;
                } // END - if
 
-               $this->partialStub('errorCode='.$errorCode.',rawData[] = '.gettype($rawData).'('.strlen($rawData).')');
+               // @TODO We need to somehow detect the state/status of the remote peer and still maintain good speed.
+               // @TODO So maybe some pre-instancing of classes might help here to speedup this I/O intensive process.
+               $this->partialStub('errorCode=' . $errorCode . ',rawData[] = ' . gettype($rawData) . '(' . strlen($rawData) . ')');
        }
 }