Exceptions got moved to 'core' as well

diff --git a/application/hub/exceptions/lists/class_InvalidListHashException.php b/application/hub/exceptions/lists/class_InvalidListHashException.php
index 871bf26f21718cbfc352401938f6be4dace2a439..30eb3503bc92c2410f71d7a21a10626034038244 100644 (file)
--- a/application/hub/exceptions/lists/class_InvalidListHashException.php
+++ b/application/hub/exceptions/lists/class_InvalidListHashException.php
@@ -31,7 +31,7 @@ class InvalidListHashException extends FrameworkException {
         */
        public function __construct (array $messageArray, $code) {
                // Construct the message
-               $message = sprintf("[%s:%d] Hash <span class=\"exception_reason\">%s</span> with key <span class=\"exception_reason\">%s</span> is invalid.",
+               $message = sprintf("[%s:%d] Hash %s with key %s is invalid.",
                        $messageArray[0]->__toString(),
                        $this->getLine(),
                        $messageArray[1],

diff --git a/application/hub/exceptions/lists/class_ListGroupAlreadyAddedException.php b/application/hub/exceptions/lists/class_ListGroupAlreadyAddedException.php
index 31b4c3a90a0db3cc9e7d36faabe8bd706a8b326c..b9ecfc0a326287f75243c29fd68e1afbcfc171f0 100644 (file)
--- a/application/hub/exceptions/lists/class_ListGroupAlreadyAddedException.php
+++ b/application/hub/exceptions/lists/class_ListGroupAlreadyAddedException.php
@@ -31,7 +31,7 @@ class ListGroupAlreadyAddedException extends FrameworkException {
         */
        public function __construct (array $messageArray, $code) {
                // Construct the message
-               $message = sprintf("[%s:%d] List group <span class=\"exception_reason\">%s</span> has already been added.",
+               $message = sprintf("[%s:%d] List group %s has already been added.",
                        $messageArray[0]->__toString(),
                        $this->getLine(),
                        $messageArray[1]

diff --git a/application/hub/exceptions/lists/class_NoListGroupException.php b/application/hub/exceptions/lists/class_NoListGroupException.php
index f2468cce7163da033553ecb360c58b1084726b77..55766b26199f1b2c24d4cf74a9ee6658b14359f8 100644 (file)
--- a/application/hub/exceptions/lists/class_NoListGroupException.php
+++ b/application/hub/exceptions/lists/class_NoListGroupException.php
@@ -31,7 +31,7 @@ class NoListGroupException extends FrameworkException {
         */
        public function __construct (array $messageArray, $code) {
                // Construct the message
-               $message = sprintf("[%s:%d] List group <span class=\"exception_reason\">%s</span> was not found.",
+               $message = sprintf("[%s:%d] List group %s was not found.",
                        $messageArray[0]->__toString(),
                        $this->getLine(),
                        $messageArray[1]

diff --git a/application/hub/exceptions/tags/class_InvalidTagException.php b/application/hub/exceptions/tags/class_InvalidTagException.php
index 890e2f0819c9bad882f74e75c765566f2db129f8..4549918834a7be7da61587c5671a24f8fae3256f 100644 (file)
--- a/application/hub/exceptions/tags/class_InvalidTagException.php
+++ b/application/hub/exceptions/tags/class_InvalidTagException.php
@@ -31,7 +31,7 @@ class InvalidTagException extends FrameworkException {
         */
        public function __construct (array $messageArray, $code) {
                // Construct the message
-               $message = sprintf("[%s:%d] Tag <span class=\"exception_reason\">%s</span> is invalid.",
+               $message = sprintf("[%s:%d] Tag %s is invalid.",
                        $messageArray[0]->__toString(),
                        $this->getLine(),
                        $messageArray[1]

diff --git a/docs/TODOs.txt b/docs/TODOs.txt
index cfcc1db3bbecefa7a965c616c0c1e54320398d06..71e067255ca9865633cd9176d0e3cdd6126a1ffa 100644 (file)
--- a/docs/TODOs.txt
+++ b/docs/TODOs.txt
@@ -1,14 +1,14 @@
 ### WARNING: THIS FILE IS AUTO-GENERATED BY ./todo-builder.sh ###
 ### DO NOT EDIT THIS FILE. ###
 ./application/hub/config.php:592:// @TODO This and the next value is very static again
-./application/hub/config.php:653:// @TODO This is very static, rewrite it to more flexible
+./application/hub/config.php:656:// @TODO This is very static, rewrite it to more flexible
 ./application/hub/interfaces/chat/class_Chatter.php:10: * @todo                We need to find a better name for this interface
 ./application/hub/interfaces/cruncher/class_CruncherHelper.php:10: * @todo             We need to find a better name for this interface
 ./application/hub/interfaces/helper/connections/class_ConnectionHelper.php:10: * @todo         Please find another name for this interface
 ./application/hub/interfaces/helper/connections/class_ConnectionHelper.php:38:  * @todo        We may want to implement a filter for ease notification of other objects like our pool
 ./application/hub/interfaces/helper/messages/class_MessageHelper.php:10: * @todo               Please find another name for this interface
 ./application/hub/interfaces/nodes/class_NodeHelper.php:10: * @todo            We need to find a better name for this interface
-./application/hub/main/class_BaseHubSystem.php:490:                            // @TODO On some systems it is 134, on some 107?
+./application/hub/main/class_BaseHubSystem.php:491:                            // @TODO On some systems it is 134, on some 107?
 ./application/hub/main/commands/console/class_HubConsoleChatCommand.php:107:    * @todo        Should we add some more filters?
 ./application/hub/main/commands/console/class_HubConsoleChatCommand.php:58:     * @todo        Try to create a ChatActivationTask or so
 ./application/hub/main/commands/console/class_HubConsoleCruncherCommand.php:107:        * @todo        Should we add some more filters?
@@ -36,10 +36,10 @@
 ./application/hub/main/filter/chat/class_ChatPhpRequirementsFilter.php:55:      * @todo        Add more test and try to add an extra message to the thrown exception
 ./application/hub/main/filter/chat/class_ChatWelcomeTeaserFilter.php:55:        * @todo        Handle over the $responseInstance to outputConsoleTeaser()
 ./application/hub/main/filter/cruncher/class_CruncherInitializationFilter.php:54:       * @todo        0% done
-./application/hub/main/filter/cruncher/class_CruncherInitializationFilter.php:87:                      // @TODO Can we rewrite this to app_die() ?
+./application/hub/main/filter/cruncher/class_CruncherInitializationFilter.php:87:                      // @TODO Can we rewrite this to app_exit() ?
 ./application/hub/main/filter/cruncher/class_CruncherPhpRequirementsFilter.php:55:      * @todo        Add more test and try to add an extra message to the thrown exception
 ./application/hub/main/filter/cruncher/class_CruncherWelcomeTeaserFilter.php:55:        * @todo        Handle over the $responseInstance to outputConsoleTeaser()
-./application/hub/main/filter/node/class_NodeInitializationFilter.php:87:                      // @TODO Can we rewrite this to app_die() ?
+./application/hub/main/filter/node/class_NodeInitializationFilter.php:87:                      // @TODO Can we rewrite this to app_exit() ?
 ./application/hub/main/filter/node/class_NodePhpRequirementsFilter.php:55:      * @todo        Add more test and try to add an extra message to the thrown exception
 ./application/hub/main/filter/node/class_NodeWelcomeTeaserFilter.php:55:        * @todo        Handle over the $responseInstance to outputConsoleTeaser()
 ./application/hub/main/filter/shutdown/node/class_NodeShutdownDeinitQueuesFilter.php:55:        * @todo        0% done
@@ -53,13 +53,12 @@
 ./application/hub/main/filter/task/node/class_NodeTaskHandlerInitializerFilter.php:55:  * @todo        Maybe some more tasks needs to be added?
 ./application/hub/main/handler/message-types/class_BaseMessageHandler.php:101:  * @todo        Add something more, e.g. spreading information over DHT
 ./application/hub/main/handler/message-types/self-connect/class_NodeMessageSelfConnectHandler.php:71:                  // @TODO Throw an exception here instead of dying
-./application/hub/main/handler/network/class_BaseRawDataHandler.php:148:        * @todo        This method will be moved to a better place
 ./application/hub/main/handler/network/udp/class_UdpRawDataHandler.php:58:      * @todo        0%
 ./application/hub/main/handler/tasks/class_TaskHandler.php:138:                // @TODO Messurement can be added around this call
 ./application/hub/main/helper/connection/class_BaseConnectionHelper.php:203:                   // @TODO Move this to the socket error handler
 ./application/hub/main/helper/connection/class_BaseConnectionHelper.php:231:    * @todo        Rewrite the while() loop to a iterator to not let the software stay very long here
 ./application/hub/main/helper/connection/tcp/class_TcpConnectionHelper.php:10: * @todo         Find an interface for hub helper
-./application/hub/main/helper/connection/tcp/class_TcpConnectionHelper.php:142:         * @todo        We may want to implement a filter for ease notification of other objects like our pool
+./application/hub/main/helper/connection/tcp/class_TcpConnectionHelper.php:139:         * @todo        We may want to implement a filter for ease notification of other objects like our pool
 ./application/hub/main/helper/connection/tcp/class_TcpConnectionHelper.php:49:  * @todo        $errorCode/-Message are now in handleSocketError()'s call-back methods
 ./application/hub/main/helper/connection/tcp/class_TcpConnectionHelper.php:86:         // @TODO The whole resolving part should be moved out and made more configurable
 ./application/hub/main/helper/connection/udp/class_UdpConnectionHelper.php:10: * @todo         Find an interface for hub helper
@@ -85,11 +84,12 @@
 ./application/hub/main/nodes/boot/class_HubBootNode.php:102:    * @todo        Unfinished method
 ./application/hub/main/nodes/boot/class_HubBootNode.php:122:           // @TODO Add some filters here
 ./application/hub/main/nodes/boot/class_HubBootNode.php:58:     * @todo        add some more special bootstrap things for this boot node
-./application/hub/main/nodes/class_BaseHubNode.php:443:         * @todo        Try to make this method more generic so we can move it in BaseFrameworkSystem
-./application/hub/main/nodes/class_BaseHubNode.php:483:         * @todo        Change the first if() block to check for a specific state
-./application/hub/main/nodes/class_BaseHubNode.php:656:                // @TODO Add some criteria, e.g. if the node is active or so
-./application/hub/main/nodes/class_BaseHubNode.php:714:         * @todo        Add checking if this node has been announced to the sender node
-./application/hub/main/nodes/class_BaseHubNode.php:756:         * @todo        Find more to do here
+./application/hub/main/nodes/class_BaseHubNode.php:445:         * @todo        Try to make this method more generic so we can move it in BaseFrameworkSystem
+./application/hub/main/nodes/class_BaseHubNode.php:485:         * @todo        Change the first if() block to check for a specific state
+./application/hub/main/nodes/class_BaseHubNode.php:658:                // @TODO Add some criteria, e.g. if the node is active or so
+./application/hub/main/nodes/class_BaseHubNode.php:716:         * @todo        Add checking if this node has been announced to the sender node
+./application/hub/main/nodes/class_BaseHubNode.php:758:         * @todo        Find more to do here
+./application/hub/main/nodes/class_BaseHubNode.php:770:         * @todo        Handle thrown exception
 ./application/hub/main/nodes/list/class_HubListNode.php:58:     * @todo        Implement more bootstrap steps
 ./application/hub/main/nodes/list/class_HubListNode.php:68:     * @todo        Unfinished method
 ./application/hub/main/nodes/list/class_HubListNode.php:91:            // @TODO Add some filters here
@@ -99,16 +99,16 @@
 ./application/hub/main/nodes/regular/class_HubRegularNode.php:58:       * @todo        Implement this method
 ./application/hub/main/nodes/regular/class_HubRegularNode.php:68:       * @todo        Unfinished method
 ./application/hub/main/nodes/regular/class_HubRegularNode.php:91:              // @TODO Add some filters here
-./application/hub/main/package/class_NetworkPackage.php:1079:   * @todo        Implement verification of all sent tags here?
+./application/hub/main/package/class_NetworkPackage.php:1083:   * @todo        Implement verification of all sent tags here?
 ./application/hub/main/package/class_NetworkPackage.php:23: * @todo            Needs to add functionality for handling the object's type
-./application/hub/main/package/class_NetworkPackage.php:300:           // @TODO crc32() is very weak, but it needs to be fast
-./application/hub/main/package/class_NetworkPackage.php:371:           // @TODO crc32() is very weak, but it needs to be fast
-./application/hub/main/package/class_NetworkPackage.php:528:                   // @TODO We may want to do somthing more here?
-./application/hub/main/package/class_NetworkPackage.php:566:    * @todo        Unfinished area, signatures are currently NOT fully supported
-./application/hub/main/package/class_NetworkPackage.php:676:                   // @TODO Add some logging here
-./application/hub/main/package/class_NetworkPackage.php:808:                   // @TODO Add some logging here
-./application/hub/main/package/class_NetworkPackage.php:959:    * @todo        This may be enchanced for outgoing packages?
-./application/hub/main/package/class_NetworkPackage.php:990:            * @todo Unsupported feature of "signed" messages commented out
+./application/hub/main/package/class_NetworkPackage.php:304:           // @TODO crc32() is very weak, but it needs to be fast
+./application/hub/main/package/class_NetworkPackage.php:375:           // @TODO crc32() is very weak, but it needs to be fast
+./application/hub/main/package/class_NetworkPackage.php:532:                   // @TODO We may want to do somthing more here?
+./application/hub/main/package/class_NetworkPackage.php:570:    * @todo        Unfinished area, signatures are currently NOT fully supported
+./application/hub/main/package/class_NetworkPackage.php:680:                   // @TODO Add some logging here
+./application/hub/main/package/class_NetworkPackage.php:812:                   // @TODO Add some logging here
+./application/hub/main/package/class_NetworkPackage.php:963:    * @todo        This may be enchanced for outgoing packages?
+./application/hub/main/package/class_NetworkPackage.php:994:            * @todo Unsupported feature of "signed" messages commented out
 ./application/hub/main/package/fragmenter/class_PackageFragmenter.php:275:      * @todo        Implement a way to send non-announcement packages with extra-salt
 ./application/hub/main/package/fragmenter/class_PackageFragmenter.php:427:      * @todo        $helperInstance is unused
 ./application/hub/main/producer/cruncher/keys/class_CruncherKeyProducer.php:106:                       // @TODO Do something with it
@@ -122,8 +122,7 @@
 ./application/hub/main/states/node/init/class_NodeInitState.php:60:     * @todo        We might want to move some calls to this method to fill it with life
 ./application/hub/main/statistics/connection/class_ConnectionStatisticsHelper.php:11: * @todo          Find an interface for hub helper
 ./application/hub/main/statistics/connection/class_ConnectionStatisticsHelper.php:98:          // @TODO last_update is not being used at the moment
-./application/hub/main/streams/raw_data/input/class_RawDataInputStream.php:57:  * @todo        Do we need to do something more here?
-./application/hub/main/streams/raw_data/output/class_RawDataOutputStream.php:53:        * @todo        Do we need to do something more here?
+./application/hub/main/streams/raw_data/input/class_RawDataInputStream.php:58:  * @todo        Do we need to do something more here?
 ./application/hub/main/tasks/chat/class_ChatTelnetListenerTask.php:53:  * @todo        Maybe visit some sub-objects
 ./application/hub/main/tasks/chat/class_ChatTelnetListenerTask.php:64:  * @todo        0%
 ./application/hub/main/tasks/cruncher/class_CruncherKeyProducerTask.php:53:     * @todo        Maybe visit some sub-objects
@@ -158,10 +157,11 @@
 ./inc/classes/exceptions/main/class_MissingMethodException.php:13: * @todo             Try to rewrite user/guest login classes and mark this exception as deprecated
 ./inc/classes/exceptions/main/class_NoConfigEntryException.php:10: * @todo             Rename this class to NoFoundEntryException
 ./inc/classes/interfaces/class_FrameworkInterface.php:11: * @todo              Find a better name for this interface
-./inc/classes/main/class_BaseFrameworkSystem.php:1684:  * @todo        Write a logging mechanism for productive mode
-./inc/classes/main/class_BaseFrameworkSystem.php:1698:                 // @TODO Finish this part!
+./inc/classes/main/class_BaseFrameworkSystem.php:1721:  * @todo        Write a logging mechanism for productive mode
+./inc/classes/main/class_BaseFrameworkSystem.php:1735:                 // @TODO Finish this part!
 ./inc/classes/main/class_BaseFrameworkSystem.php:195:  // @todo Try to clean these constants up
-./inc/classes/main/class_BaseFrameworkSystem.php:476:   * @todo        SearchableResult and UpdateableResult shall have a super interface to use here
+./inc/classes/main/class_BaseFrameworkSystem.php:413:          // @TODO __CLASS__ does always return BaseFrameworkSystem but not the extending (=child) class
+./inc/classes/main/class_BaseFrameworkSystem.php:487:   * @todo        SearchableResult and UpdateableResult shall have a super interface to use here
 ./inc/classes/main/commands/web/class_WebLoginAreaCommand.php:64:       * @todo        Add some stuff here: Some personal data, app/game related data
 ./inc/classes/main/commands/web/class_WebProblemCommand.php:58:         * @todo        0% done
 ./inc/classes/main/commands/web/class_WebStatusCommand.php:58:  * @todo        0% done
@@ -184,13 +184,14 @@
 ./inc/classes/main/criteria/search/class_SearchCriteria.php:70:         * @todo        Find a nice casting here. (int) allows until and including 32766.
 ./inc/classes/main/database/databases/class_LocalFileDatabase.php:304:  * @todo        Do some checks on the database directory and files here
 ./inc/classes/main/decorator/template/class_XmlRewriterTemplateDecorator.php:426:       * @todo        Find something useful with this!
-./inc/classes/main/discovery/payment/class_LocalPaymentDiscovery.php:82:        * @todo        0% done
+./inc/classes/main/discovery/payment/class_LocalPaymentDiscovery.php:88:        * @todo        0% done
 ./inc/classes/main/filter/change/class_EmailChangeFilter.php:54:        * @todo        Implement email change of the user here. HINT: Use the User class!
 ./inc/classes/main/filter/change/class_PasswordChangeFilter.php:55:     * @todo        Finished updating user password hash here. HINT: Use the User class again.
 ./inc/classes/main/filter/news/class_NewsProcessFilter.php:55:  * @todo        Unfinished stub, add functionality here
 ./inc/classes/main/filter/payment/class_PaymentDiscoveryFilter.php:97:  * @todo        0% done
 ./inc/classes/main/filter/update/class_UserUpdateFilter.php:55:         * @todo        Add more user updates here
 ./inc/classes/main/filter/verifier/class_AccountPasswordVerifierFilter.php:57:  * @todo        Rewrite handling of different password fields
+./inc/classes/main/handler/raw_data/class_BaseRawDataHandler.php:146:   * @todo        This method will be moved to a better place
 ./inc/classes/main/helper/class_BaseHelper.php:173:     * @todo        Rewrite this method using a helper class for filtering data
 ./inc/classes/main/helper/class_BaseHelper.php:202:                    // @TODO Try to log it here
 ./inc/classes/main/helper/web/forms/class_WebFormHelper.php:102:        * @todo        Add some unique PIN here to bypass problems with some browser and/or extensions
@@ -248,6 +249,7 @@
 ./inc/classes/main/user/class_BaseUser.php:80:  * @todo        Find a way of casting here. "(int)" might destroy the user id > 32766
 ./inc/classes/main/user/member/class_Member.php:84:     * @todo        Add more ways over creating user classes
 ./inc/classes/middleware/debug/class_DebugMiddleware.php:113:                  // @TODO Initialization phase
+./inc/classes/middleware/io/class_FileIoHandler.php:133:                       // @TODO What is this for?
 ./inc/classes.php:10: * @todo          We should minimize these includes
 ./inc/config/class_FrameworkConfiguration.php:212:      * @todo        We have to add some more entries from $_SERVER here
 ./inc/database.php:11: * @todo         We should minimize these includes
@@ -261,10 +263,15 @@
 ./inc/selector.php:11: * @todo         We should minimize these includes
 ./index.php:57:         * @todo        This method is old code and needs heavy rewrite and should be moved to ApplicationHelper
 ### ### DEPRECATION FOLLOWS: ### ###
+./application/hub/main/handler/class_BaseHandler.php:2:// @DEPRECATED
 ./application/hub/main/handler/message-types/class_NodeMessageAnnouncementHandler.php:2:// @DEPRECATED
+./application/hub/main/handler/network/class_BaseRawDataHandler.php:2:// @DEPRECATED
 ./application/hub/main/helper/hub/announcement/class_HubDescriptorHelper.php:2:// @DEPRECATED
 ./application/hub/main/nodes/class_BaseHubNode.php:53:  * @deprecated
 ./inc/classes/exceptions/main/class_MissingMethodException.php:14: * @deprecated       Please do no longer use this exception
+./inc/classes/interfaces/database/backend/class_DatabaseFrontendInterface.php:2:// @DEPRECATED
+./inc/classes/interfaces/database/frontend/class_DatabaseFrontendInterface.php:2:// @DEPRECATED
+./inc/classes/main/database/class_BaseDatabaseFrontend.php:2:// @DEPRECATED
 ./inc/classes.php:9: * @deprecated
 ./inc/database.php:10: * @deprecated
 ./inc/hooks.php:10: * @deprecated