Roland Häder [Fri, 16 Jul 2010 15:34:57 +0000 (15:34 +0000)]
Syntax errors fixed, naming convention applied, wrappers used:
- Some syntax errors fixed (were added with last commit)
- Naming convention applied on variables $max ($numMenus) and some more
- Wraper countSumTotalData() further used
- overview-inc.php contained a query which can be converted into a wrapper call,
function isExtensionInstalled() could be used instead
- TODOs.txt updated
Roland Häder [Fri, 16 Jul 2010 03:49:23 +0000 (03:49 +0000)]
More language strings renamed, TODOs.txt updated:
- A lot more language strings renamed (naming convention: ADMIN_, GUEST_,
MEMBER_ and SPONSOR_ are used for "level" specific language strings, for all
currently no prefix is used.
- HTML code moved out to template
- TODOs.txt updated
Roland Häder [Thu, 15 Jul 2010 18:23:34 +0000 (18:23 +0000)]
Several template fixes/code cleanups, default module titles added:
- Several template fixes/cleanups, e.g. class="bottom" was missing, array
elements were renamed but not in templates
- Code cosmetics applied
- Default module titles will now be set if no module title is already entered
Roland Häder [Sun, 11 Jul 2010 20:27:15 +0000 (20:27 +0000)]
Some more wrappers added, code cleanups:
- Configuration 'wernis_userid' rewritten to {?wernis_refid?}
- New wrapper getIndexHome() added
- New wrapper getDoublerUserid() added (and a global array element rewritten)
- Doublicate braces (('foo')) cleaned up
- Some code costemtics applied
- Other minor improvements
Roland Häder [Sun, 11 Jul 2010 19:55:12 +0000 (19:55 +0000)]
Fixes for doubler (not fully fixed) and rewrites for beg/doubler:
- Many fixes for doubler link (was broken due to bad EL syntax)
- Rewrites to make lesser use of SOME_FOO_1/SOME_FOO_2 (should be SOME_FOO)
- Fixes for beg extension
- TODOs.txt updated
Roland Häder [Sat, 10 Jul 2010 08:51:00 +0000 (08:51 +0000)]
New wrapper function introduced, more EL rewrites:
- New wrapper function getTotalPoints() introduced
- Even more rewrites to make usage of EL
- TODOs.txt updated
Roland Häder [Thu, 8 Jul 2010 22:17:38 +0000 (22:17 +0000)]
Rewrites to handle non-existent modules:
- Getting module' title is now done while compilation phase (and not when the
filter runs). This allows us to modify it even after the page header has been
loaded.
- TODOs.txt updated
Roland Häder [Tue, 6 Jul 2010 07:01:51 +0000 (07:01 +0000)]
Rewrites for installation phase:
- All localized installer messages should be located in install_XX.php
- All those messages should have a prefix INSTALLER_
- Fatal errors in installation phase are now no longer handled by our fatal
error handler, instead the installer handles them by itself.
- Another old message id part "LANG" removed
- TODOs.txt updated
Roland Häder [Sun, 4 Jul 2010 12:55:21 +0000 (12:55 +0000)]
Fixes for missing arguments and some improvements:
- Fixes for missing arguments of debug_report_bug() in various placed
- readFromFile() does already check if the file is readable, so no other
function need to call debug_report_bug() if it is not readable
- TODOs.txt updated
Roland Häder [Fri, 2 Jul 2010 03:28:02 +0000 (03:28 +0000)]
Naming convention, internal TODOs solved:
- Naming convention says referal ids should be represented as 'refid' and not
'rid' which is to short
- Internal TODO solved which wants us to make usage of addPointsFoo() function
- TODOs.txt updated
Roland Häder [Thu, 1 Jul 2010 01:47:07 +0000 (01:47 +0000)]
API functions renamed:
- getOutputMode() is now known as getScriptOutputMode()
- getCachedOutputMode() is now known as getOutputMode()
- This solves a conflict shown in previous commit
Roland Häder [Thu, 1 Jul 2010 01:43:30 +0000 (01:43 +0000)]
A lot calls saved, expression language rewritten:
- A lot getConfig() calls saved and wrapped: getConfig('FOO_BAR') can now be
done with getFooBar(), except OUTPUT_MODE: getCachedOutputMode(). We need to
fix that later on.
- Expression language rewritten (and cached) to take a look for above wrapper
functions.
- TODOs.txt updated
Roland Häder [Wed, 30 Jun 2010 23:51:59 +0000 (23:51 +0000)]
Module-related code moved, deprecated templates deleted, internals stats are now configurable
- Internal statistics can now be turned of to gain a little more performance
- Module-related functions moved to module-functions.php
- Deprecated templates removed
- TODOs.txt updated
Roland Häder [Wed, 30 Jun 2010 11:18:36 +0000 (11:18 +0000)]
Some templates renamed, fixed of double-init of extension notes:
- Some templates renamed, new naming convention says that _ext_ is a shortcut
for _extension_ and therefore it is outdated.
- Double-initialization of extension notes while displaying them in task fixed
- In same place, counting of SQL queries fixed
- TODOs.txt updated
Roland Häder [Wed, 30 Jun 2010 04:54:59 +0000 (04:54 +0000)]
Fixed missed [sw] things in a lot templates, added more EL:
- Fixed a lot broken switch_swX in templates to make use of EL function
{%template,ColorSwitch%}
- More usage of fixEmptyContentToDashes() e.g. for nicknames
- TODOs.txt updated
Roland Häder [Tue, 29 Jun 2010 01:19:13 +0000 (01:19 +0000)]
A lot code rewritten:
- New template-functions.php added and a lot functions moved from functions.php
and some from wrapper-functions.php to it.
- New EL function doExpressionTemplate() added
- New template function doTemplateColorSwitch() added
- Heavy rewrite of PHP code and templates to make usage of that new function
which should result in an easier PHP code
- Some fixes
- TODOs.txt updated
Roland Häder [Mon, 28 Jun 2010 23:25:01 +0000 (23:25 +0000)]
Changed all admin getter, closed internal TODOs:
- All admin getter functions like getAdminEmail() (except getAdminId()) does now
take the admin id
- Naming convention on some template names applied
- Some deprecated footer/header templates merged and marked as deprecated
- TODOs.txt updated
Roland Häder [Mon, 28 Jun 2010 21:38:03 +0000 (21:38 +0000)]
New (template) wrapper function fixEmptyContentToDashes() introduced, EL rewrites:
- New (template) wrapper function fixEmptyContentToDashes() introduced, this
function should help template writers to deal with empty content. If an empty
string is detected, it got converted into three dashes. This may fix some
issues with empty div and/or td tags.
- Even more rewrites to make use of EL
- TODOs.txt updated
Roland Häder [Mon, 28 Jun 2010 19:25:00 +0000 (19:25 +0000)]
Task-create functions does now return a task id. We use that to help registering a new extension which has no task entry yet while we update an already installed extension
Roland Häder [Mon, 28 Jun 2010 07:07:51 +0000 (07:07 +0000)]
Deprecated variables for templates removed, mor EL-rewrites, getMessage() rewritten:
- Deprecated variables $nick and $email removed from loadEmailTemplate()
- More rewrites for usage of EL
- getMessage() lesser used (saves a lot calls while execution of include file)
- Some internal TODOs closed
- TODOs.txt updated
Roland Häder [Mon, 28 Jun 2010 05:14:11 +0000 (05:14 +0000)]
New extension added, more EL-rewrites, naming-convention applied:
- New extension 'ext-timezone' added to more easilier change the timezone
this installation runs with. It is essential to install this extension and
keep it active.
- Even more rewrites to make use of EL
- theme_ver is outdated, we use theme_version (no short-cutted texts)
- TODOs.txt updated
Roland Häder [Mon, 28 Jun 2010 03:47:11 +0000 (03:47 +0000)]
New function isValidUserid() introduced, more rewrites to EL:
- New function isValidUserId() introduced, see ticket #147. This function just
validates a given user id if it not null, not empty and larget than zero.
- More rewrites to make use of EL
- 'surfbar_counter' is now a CSS class, not id
- TODOs.txt updated
Roland Häder [Wed, 23 Jun 2010 21:38:33 +0000 (21:38 +0000)]
New debugging function debugOutput() introduced, some rewrites to EL:
- New debugging function debugOutput() added, this function does output any
XHTML message in a div-block to the browser.
- Some more rewrites to EL
- TODOs.txt updated
Roland Häder [Wed, 23 Jun 2010 13:49:46 +0000 (13:49 +0000)]
Simplified some more code:
- addEmailNavigation() is now located in admin-inc.php because only admin
actions will make use of it
- Same function simplified, if only one page should be made navigateable, the
function returns an empty string
- There was another unencapsulated what=list_unconfirmed
Roland Häder [Wed, 23 Jun 2010 13:26:45 +0000 (13:26 +0000)]
Even more fixes/improvements:
- Added filter pre_youhere_line. It will be executed directly before the
div-block of the 'You are here' navigation
- Saved an else-block and br-tag in same function
- For that missing br-tag a CSS 'margin-bottom' needs to be added to
you_are_here CSS class
- Fixed default value for an enum in ext-removeip in the configuration SQL query
Roland Häder [Wed, 23 Jun 2010 12:49:06 +0000 (12:49 +0000)]
Some fixes/improvements:
- Fixed missing array elements for what=active in guest menu
- 'Today Online' below action=online is only shown when ext-active and
ext-online are activated
- Fixed user's last activity in clicking on paidmails. It is now no longer
updated if an administrator is logged in