Use field width limits with fscanf().

Cppcheck warns that unlimited field withs can lead to crashes with huge files.

diff --git a/src/init.cpp b/src/init.cpp
index 861af140aa8795a5151c1f972b698fbd644edef8..90617b0ffefb8b7d7e0be040c16d1604af6754c6 100644 (file)
--- a/src/init.cpp
+++ b/src/init.cpp
@@ -144,7 +144,7 @@ bool loadConfig()
                return true;
        }
 
-       fscanf(fp, "%f %d", &version, &release);
+       fscanf(fp, "%10f %10d", &version, &release);
 
        debug(("Version = %.2f - Expected %.2f\n", version, VERSION));
        debug(("Release = %d - Expected %d\n", release, RELEASE));
@@ -154,7 +154,7 @@ bool loadConfig()
                rtn = true;
        }
 
-       fscanf(fp, "%d %d %d %d %d %d %d", &engine.fullScreen, &game.musicVol, &game.soundVol, &game.output, &game.brightness, &engine.extremeAvailable, &game.gore);
+       fscanf(fp, "%10d %10d %10d %10d %10d %10d %10d", &engine.fullScreen, &game.musicVol, &game.soundVol, &game.output, &game.brightness, &engine.extremeAvailable, &game.gore);
 
        fclose(fp);
 
@@ -223,7 +223,7 @@ int initMedalService(void *data)
                return 0;
        }
        
-       fscanf(fp, "%s", privateKey);
+       fscanf(fp, "%19s", privateKey);
        
        fclose(fp);