Don't write the config file when --skip-config flag is given to the installer.

* scripts/installer_cli.php: Read the arguments list before checking
  if the config file is writeable.

diff --git a/lib/installer.php b/lib/installer.php
index 346c706d61aab1fd4fe8a05363c4edd72e8c64be..e73216f18d42b3ebc1b62d816e1f5b507dc0dd6c 100644 (file)
--- a/lib/installer.php
+++ b/lib/installer.php
@@ -85,7 +85,7 @@ abstract class Installer
         $pass = true;
 
         $config = INSTALLDIR.'/config.php';
-        if (file_exists($config)) {
+        if (!$this->skipConfig && file_exists($config)) {
             if (!is_writable($config) || filesize($config) > 0) {
                 if (filesize($config) == 0) {
                     $this->warning('Config file "config.php" already exists and is empty, but is not writable.');
@@ -126,14 +126,16 @@ abstract class Installer
         }
 
         // @fixme this check seems to be insufficient with Windows ACLs
-        if (!is_writable(INSTALLDIR)) {
+        if (!$this->skipConfig && !is_writable(INSTALLDIR)) {
             $this->warning(sprintf('Cannot write config file to: <code>%s</code></p>', INSTALLDIR),
                            sprintf('On your server, try this command: <code>chmod a+w %s</code>', INSTALLDIR));
             $pass = false;
         }
 
         // Check the subdirs used for file uploads
-        $fileSubdirs = array('avatar', 'file');
+        // TODO get another flag for this --skipFileSubdirCreation
+        if (!$this->skipConfig) {
+            $fileSubdirs = array($this->avatarDir, $this->fileDir);
         foreach ($fileSubdirs as $fileSubdir) {
             $fileFullPath = INSTALLDIR."/$fileSubdir";
             if (!file_exists($fileFullPath)) {
@@ -148,7 +150,7 @@ abstract class Installer
                 $pass = false;
             }
         }
-
+        }
         return $pass;
     }
 
@@ -580,10 +582,10 @@ abstract class Installer
             return false;
         }
 
+        if (!$this->skipConfig) {
         // Make sure we can write to the file twice
         $oldUmask = umask(000); 
 
-        if (!$this->skipConfig) {
             $this->updateStatus("Writing config file...");
             $res = $this->writeConf();
 
@@ -616,12 +618,12 @@ abstract class Installer
                 $this->updateStatus("Can't write to config file.", true);
                 return false;
             }
-        }
 
         // Restore original umask
         umask($oldUmask);
         // Set permissions back to something decent
         chmod(INSTALLDIR.'/config.php', 0644);
+        }
         
         $scheme = $this->ssl === 'always' ? 'https' : 'http';
         $link = "{$scheme}://{$this->server}/{$this->path}";

diff --git a/scripts/install_cli.php b/scripts/install_cli.php
index 815418aaab51ee942114700947678df4195851a9..da5f0f4b0c6add9fbed00a6d1fb5959478fcb129 100755 (executable)
--- a/scripts/install_cli.php
+++ b/scripts/install_cli.php
@@ -47,10 +47,10 @@ class CliInstaller extends Installer
      */
     function main()
     {
+        if ($this->prepare()) {
         if (!$this->checkPrereqs()) {
             return false;
         }
-        if ($this->prepare()) {
             return $this->handle();
        } else {
             $this->showHelp();